-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search Index Refactoring #3556
base: master
Are you sure you want to change the base?
Search Index Refactoring #3556
Commits on Dec 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ddc452a - Browse repository at this point
Copy the full SHA ddc452aView commit details -
idx_cleanName() was called only from Doku_Indexer::addMetaKeys(), lookupKey(), getPages(), histogram()
Configuration menu - View commit details
-
Copy full SHA for 0fb77e9 - Browse repository at this point
Copy the full SHA 0fb77e9View commit details -
This function is not called from elsewhere.
Configuration menu - View commit details
-
Copy full SHA for 1dad69b - Browse repository at this point
Copy the full SHA 1dad69bView commit details -
encapsulate idx_listIndexLengths()
Note: idx_listIndexLengths() is used in inc/infoutils.php file
Configuration menu - View commit details
-
Copy full SHA for 4316123 - Browse repository at this point
Copy the full SHA 4316123View commit details -
Note: idx_getIndex() is used in inc/infoutils.php file
Configuration menu - View commit details
-
Copy full SHA for 861eb32 - Browse repository at this point
Copy the full SHA 861eb32View commit details -
This function is not called from elsewhere.
Configuration menu - View commit details
-
Copy full SHA for e15020b - Browse repository at this point
Copy the full SHA e15020bView commit details -
Configuration menu - View commit details
-
Copy full SHA for abfaea2 - Browse repository at this point
Copy the full SHA abfaea2View commit details -
Note: idx_listIndexLengths() is used in iinc/TaskRunner.php and inc/Remote/ApiCore.php file Also used in _test files.
Configuration menu - View commit details
-
Copy full SHA for 56d1fe9 - Browse repository at this point
Copy the full SHA 56d1fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c01949 - Browse repository at this point
Copy the full SHA 8c01949View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af7b62 - Browse repository at this point
Copy the full SHA 0af7b62View commit details
Commits on Dec 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8896568 - Browse repository at this point
Copy the full SHA 8896568View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5daf9f - Browse repository at this point
Copy the full SHA b5daf9fView commit details
Commits on Dec 19, 2019
-
encapsulate functions into Classes
class FulltextSearch class MetaSearch
Configuration menu - View commit details
-
Copy full SHA for cd17dbd - Browse repository at this point
Copy the full SHA cd17dbdView commit details
Commits on Dec 20, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 83198f9 - Browse repository at this point
Copy the full SHA 83198f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d43b19d - Browse repository at this point
Copy the full SHA d43b19dView commit details
Commits on Dec 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 173bfbc - Browse repository at this point
Copy the full SHA 173bfbcView commit details
Commits on Dec 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c31af4f - Browse repository at this point
Copy the full SHA c31af4fView commit details -
make public listIndex() and listIndexLengths() method
because used in inc/infoutils.php file
Configuration menu - View commit details
-
Copy full SHA for fe21229 - Browse repository at this point
Copy the full SHA fe21229View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89b6193 - Browse repository at this point
Copy the full SHA 89b6193View commit details
Commits on Dec 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0a3e25f - Browse repository at this point
Copy the full SHA 0a3e25fView commit details -
updateTuple() accept int for the second argument
Configuration menu - View commit details
-
Copy full SHA for 115f491 - Browse repository at this point
Copy the full SHA 115f491View commit details
Commits on Dec 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f9c5d30 - Browse repository at this point
Copy the full SHA f9c5d30View commit details
Commits on Dec 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 48b9265 - Browse repository at this point
Copy the full SHA 48b9265View commit details
Commits on Jan 5, 2020
-
provides convert($query), recert_simple(), and termParser(). No needs to pass $Indexer in method's arguments.
Configuration menu - View commit details
-
Copy full SHA for 3837ea9 - Browse repository at this point
Copy the full SHA 3837ea9View commit details -
move Quicksearch methods into MetaSearch class
pageLookup() does not use fulltext index, but metadata index
Configuration menu - View commit details
-
Copy full SHA for 677f78a - Browse repository at this point
Copy the full SHA 677f78aView commit details -
Warning: Parameter 1 to dokuwiki\Search\MetaSearch::callback_pageLookup() expected to be a reference, value given in /path/to/dokuwiki/inc/Extension/Event.php on line 135
Configuration menu - View commit details
-
Copy full SHA for 6b6beca - Browse repository at this point
Copy the full SHA 6b6becaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe2d1da - Browse repository at this point
Copy the full SHA fe2d1daView commit details
Commits on Jan 7, 2020
-
PageIndex, PagewordIndex, MetadataIndex inherit the AbstractIndex class
Configuration menu - View commit details
-
Copy full SHA for f076e3f - Browse repository at this point
Copy the full SHA f076e3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86fc728 - Browse repository at this point
Copy the full SHA 86fc728View commit details -
make $pidCache static, refactor getPID()
all extending acstract classes should use a static pidCache array
Configuration menu - View commit details
-
Copy full SHA for 5aa57cb - Browse repository at this point
Copy the full SHA 5aa57cbView commit details
Commits on Jan 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5d3ae62 - Browse repository at this point
Copy the full SHA 5d3ae62View commit details
Commits on Jan 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 872fcdc - Browse repository at this point
Copy the full SHA 872fcdcView commit details
Commits on Jan 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7dcabbd - Browse repository at this point
Copy the full SHA 7dcabbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dd6e5f - Browse repository at this point
Copy the full SHA 9dd6e5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 185796b - Browse repository at this point
Copy the full SHA 185796bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 780c140 - Browse repository at this point
Copy the full SHA 780c140View commit details -
prepared for unit tests compatibility only
Configuration menu - View commit details
-
Copy full SHA for 489a7bf - Browse repository at this point
Copy the full SHA 489a7bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 839557a - Browse repository at this point
Copy the full SHA 839557aView commit details
Commits on Jan 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b47a51d - Browse repository at this point
Copy the full SHA b47a51dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ad37f3 - Browse repository at this point
Copy the full SHA 9ad37f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f4a342 - Browse repository at this point
Copy the full SHA 3f4a342View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cba610 - Browse repository at this point
Copy the full SHA 0cba610View commit details
Commits on Jan 15, 2020
-
remove global FT_SNIPPET_NUMBER
it is defined as namespace constant in Search/FulltextSearch.php file, and used in Remote/ApiCore.php and Ui/Search.php files.
Configuration menu - View commit details
-
Copy full SHA for a991224 - Browse repository at this point
Copy the full SHA a991224View commit details -
Configuration menu - View commit details
-
Copy full SHA for efe7080 - Browse repository at this point
Copy the full SHA efe7080View commit details -
Does it solve scrutinizer inspection? The expression ``$this->addIndexKey('page', '', $page);`` of type ``false|integer|string`` adds the type ``string`` to the return on line 73 which is incompatible with the return type documented by ``dokuwiki\Search\AbstractIndex::getPID`` of type ``integer|false``.
Configuration menu - View commit details
-
Copy full SHA for 166288e - Browse repository at this point
Copy the full SHA 166288eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 196d73d - Browse repository at this point
Copy the full SHA 196d73dView commit details
Commits on Jan 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2cbd2b9 - Browse repository at this point
Copy the full SHA 2cbd2b9View commit details
Commits on Jan 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 46b8351 - Browse repository at this point
Copy the full SHA 46b8351View commit details -
move lookup() to PagewordIndex class, reduce term 'Indexer'
make similar MetadataIndex::lookupKey() and PagewordIndex::lookup()
Configuration menu - View commit details
-
Copy full SHA for be5c1ea - Browse repository at this point
Copy the full SHA be5c1eaView commit details -
replace idx_* and ft_* functions with relevant class metods
Configuration menu - View commit details
-
Copy full SHA for bb38a88 - Browse repository at this point
Copy the full SHA bb38a88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bff05a - Browse repository at this point
Copy the full SHA 8bff05aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c562873 - Browse repository at this point
Copy the full SHA c562873View commit details
Commits on Jan 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 094ebf2 - Browse repository at this point
Copy the full SHA 094ebf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d756b1c - Browse repository at this point
Copy the full SHA d756b1cView commit details -
define getPages() in AbstractIndex instead of PageIndex
getPages() is inherited to each subclass of AbstractIndex, but MetadataIndex::getPages() will override the inherited method.
Configuration menu - View commit details
-
Copy full SHA for 02361d2 - Browse repository at this point
Copy the full SHA 02361d2View commit details
Commits on Jan 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 39cb9fc - Browse repository at this point
Copy the full SHA 39cb9fcView commit details
Commits on Jan 29, 2020
-
getPID() : mark deleted page entry in page.idx getPIDNoLock() : obsoleted getPages() : exclude deleted pages
Configuration menu - View commit details
-
Copy full SHA for f36fd30 - Browse repository at this point
Copy the full SHA f36fd30View commit details
Commits on Jan 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9a025b5 - Browse repository at this point
Copy the full SHA 9a025b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4027a91 - Browse repository at this point
Copy the full SHA 4027a91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f93610 - Browse repository at this point
Copy the full SHA 4f93610View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fb944f - Browse repository at this point
Copy the full SHA 8fb944fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2f3916 - Browse repository at this point
Copy the full SHA a2f3916View commit details
Commits on Jan 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e9d278b - Browse repository at this point
Copy the full SHA e9d278bView commit details -
INdexer::histogram() is only used in indexer_histogram.test.php file.
Configuration menu - View commit details
-
Copy full SHA for 4d04b7b - Browse repository at this point
Copy the full SHA 4d04b7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5237d40 - Browse repository at this point
Copy the full SHA 5237d40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 743c9a2 - Browse repository at this point
Copy the full SHA 743c9a2View commit details
Commits on Feb 1, 2020
-
obsolete fulltext.php and indexer.php files
define deprecated functions in deprecated.php file. fix load.php, loading fulltext.php and indexer.php is nolonger necessary.
Configuration menu - View commit details
-
Copy full SHA for 6f58ff6 - Browse repository at this point
Copy the full SHA 6f58ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 653b91a - Browse repository at this point
Copy the full SHA 653b91aView commit details
Commits on Feb 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4a90f94 - Browse repository at this point
Copy the full SHA 4a90f94View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2e1d0b - Browse repository at this point
Copy the full SHA f2e1d0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db87936 - Browse repository at this point
Copy the full SHA db87936View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9329b00 - Browse repository at this point
Copy the full SHA 9329b00View commit details
Commits on Feb 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fd9f989 - Browse repository at this point
Copy the full SHA fd9f989View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d2e7d - Browse repository at this point
Copy the full SHA 11d2e7dView commit details -
idx_get_indexer() returns MetadataIndex
According to the development manual, for [Metadata index](https://www.dokuwiki.org/devel:metadata#metadata_index), indexer object supports `addMetaKeys()`, `lookupKey()`, and `getpages()`. This means that `idx_get_indexer()` should return MetadataIndex object.
Configuration menu - View commit details
-
Copy full SHA for b4c31a2 - Browse repository at this point
Copy the full SHA b4c31a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f9bd52 - Browse repository at this point
Copy the full SHA 5f9bd52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51ddbad - Browse repository at this point
Copy the full SHA 51ddbadView commit details
Commits on Mar 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for abb227b - Browse repository at this point
Copy the full SHA abb227bView commit details
Commits on Mar 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 22c4cfd - Browse repository at this point
Copy the full SHA 22c4cfdView commit details -
Follow up #2985, fperm seetting
Fixed inconsistent handling of falsy values on fperm setting
Configuration menu - View commit details
-
Copy full SHA for 39f31b6 - Browse repository at this point
Copy the full SHA 39f31b6View commit details
Commits on May 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e36bcee - Browse repository at this point
Copy the full SHA e36bceeView commit details
Commits on Jun 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9de2ceb - Browse repository at this point
Copy the full SHA 9de2cebView commit details
Commits on Jun 24, 2020
-
make FulltextIndex::getIndexLengths() public
Third-party plugins may use this method. The [cloud plugin](https://github.com/dokufreaks/plugin-cloud) uses idx_indexLength().
Configuration menu - View commit details
-
Copy full SHA for 558f089 - Browse repository at this point
Copy the full SHA 558f089View commit details -
Configuration menu - View commit details
-
Copy full SHA for d42a607 - Browse repository at this point
Copy the full SHA d42a607View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22df765 - Browse repository at this point
Copy the full SHA 22df765View commit details
Commits on Sep 10, 2020
-
Merge branch 'master' into Refactor_Fulltext
* master: (111 commits) Update translation translation update don't crush tables too narrow. fixes #3250 translation update Thorough tests for EO, DE, PT and ES translation update Optimized pageRestoreConfirm function Tests for Portuguese and Spanish Changes according to revisions in moisesbr-dw#2 adjust callstack depth for deprecation message further better deprecation messages for self required plugin base files don't test on old PHP releases anymore increase minimum PHP version to 7.2 fixed tests for cleanID and romanization for Greeklish Improved the transliteration from greek to latin. extension cli: do not try to upgrade bundled plugins Public access to patterns in external link parser test the collator fallback always cleanup for collator tests wrap sorting functions into their own class ...
Configuration menu - View commit details
-
Copy full SHA for b9c8f03 - Browse repository at this point
Copy the full SHA b9c8f03View commit details -
replace user errors with exceptions
Exceptions are better to handle than errors. What I don't like is that we now have an unfortunate mix of return code and exception signalling for errors. Some methods still return false for errors while others now throw exceptions (always returning true otherwise).
Configuration menu - View commit details
-
Copy full SHA for 15f699a - Browse repository at this point
Copy the full SHA 15f699aView commit details
Commits on Sep 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 265e2c9 - Browse repository at this point
Copy the full SHA 265e2c9View commit details -
getPID(), saveIndex(), saveIndexKey(), getPageWords() return always true, otherwise exceptions.
Configuration menu - View commit details
-
Copy full SHA for a16bd54 - Browse repository at this point
Copy the full SHA a16bd54View commit details
Commits on Sep 22, 2020
-
Just ignore $value argument if $key argument is array . Ignore enpty key of $key argument. Ensure to treat any null value of $key array as empty string.
Configuration menu - View commit details
-
Copy full SHA for 89e3dd3 - Browse repository at this point
Copy the full SHA 89e3dd3View commit details
Commits on Sep 25, 2020
-
change Index objects to non-singleton
Indexer, FulltextIndex, MetadataIndex uses common directory to store *.idx files, but this does not mean they should be singleton objects to avoid lock confrictions.
Configuration menu - View commit details
-
Copy full SHA for a32da6d - Browse repository at this point
Copy the full SHA a32da6dView commit details -
instantiate *Index with numeric page id
will reduce access to static $pidCache
Configuration menu - View commit details
-
Copy full SHA for 725e8e5 - Browse repository at this point
Copy the full SHA 725e8e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5792814 - Browse repository at this point
Copy the full SHA 5792814View commit details
Commits on Sep 26, 2020
-
change Tokenizer static utility
frequently used in ajax call, singleton is not effective to reduce multiple instantiations.
Configuration menu - View commit details
-
Copy full SHA for 1755450 - Browse repository at this point
Copy the full SHA 1755450View commit details -
change MetadataSearch and FulltextSearch to non-singleton
singleton is not effective to reduce multiple instantiations, especially for MetadataSearch which is frequently used in ajax call.
Configuration menu - View commit details
-
Copy full SHA for cc3a3cd - Browse repository at this point
Copy the full SHA cc3a3cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72ebc99 - Browse repository at this point
Copy the full SHA 72ebc99View commit details
Commits on Sep 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4d69838 - Browse repository at this point
Copy the full SHA 4d69838View commit details
Commits on Nov 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9e7aeeb - Browse repository at this point
Copy the full SHA 9e7aeebView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcd7722 - Browse repository at this point
Copy the full SHA bcd7722View commit details
Commits on Nov 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c1803f3 - Browse repository at this point
Copy the full SHA c1803f3View commit details -
fix undefined array in FulltextSearch
this was already fixed by 5afd958 on 2021-02-05
Configuration menu - View commit details
-
Copy full SHA for 05606ae - Browse repository at this point
Copy the full SHA 05606aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for fab81cc - Browse repository at this point
Copy the full SHA fab81ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for a02395a - Browse repository at this point
Copy the full SHA a02395aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3df1553 - Browse repository at this point
Copy the full SHA 3df1553View commit details