Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRP Test sometimes fails with slightly violated tolerance #23

Open
janbruedigam opened this issue Mar 12, 2022 · 3 comments
Open

MRP Test sometimes fails with slightly violated tolerance #23

janbruedigam opened this issue Mar 12, 2022 · 3 comments

Comments

@janbruedigam
Copy link
Member

See for example CI#299 (attempt 1).
https://github.com/dojo-sim/Dojo.jl/actions/runs/1972726645/attempts/1

@thowell
Copy link
Member

thowell commented Mar 12, 2022

This test has been problematic before and I often have difficulty replicating it locally. The finite-difference and analytical Jacobians should match more closely. Not sure what the best fix for this is...

@janbruedigam
Copy link
Member Author

Maybe a naive question, haven't looked at the tests in detail: Why are we doing finit-diffing and not auto-diffing? Can finite-differences achieve the desired numerical accuracy?

@simon-lc
Copy link
Member

I think we started using finite-diff everywhere because it's easier to use than ForwardDiff. Especially when you are dealing with structures or functions that have a fixed element type (say Float64). Forward diff will pass it's own type and the function might break.
So this is just for convenience, and I think that most of the tests would work fine with ForwardDiff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants