Improve UserCollectionPresenter sort tests

SWDestinyTrades/Classes/UserCollection/Presenter/UserCollectionPresenter.swift

@@ -23,14 +23,17 @@ final class UserCollectionPresenter: UserCollectionPresenterProtocol {
     private let dispatchQueue: DispatchQueueType
     private let database: DatabaseProtocol?
     private let navigator: UserCollectionNavigator
+    private let manager: PopoverMenuManagerType
     private var currentSortIndex = 0
 
     init(controller: UserCollectionViewControllerProtocol,
          dispatchQueue: DispatchQueueType = DispatchQueue.main,
+         manager: PopoverMenuManagerType = PopoverMenuManager(),
          database: DatabaseProtocol?,
          navigator: UserCollectionNavigator) {
         self.controller = controller
         self.dispatchQueue = dispatchQueue
+        self.manager = manager
         self.database = database
         self.navigator = navigator
     }
@@ -114,12 +117,11 @@ final class UserCollectionPresenter: UserCollectionPresenterProtocol {
 
     @objc
     private func sort(_ sender: UIBarButtonItem, event: UIEvent) {
-        let manager = PopoverMenuManager()
         manager.showPopoverMenu(forEvent: event,
-                                with: [L10n.aToZ, L10n.cardNumber, L10n.color]) { [weak self] selectedIndex in
-            self?.controller?.sort(selectedIndex)
-            self?.currentSortIndex = selectedIndex
-        }
+                                with: [L10n.aToZ, L10n.cardNumber, L10n.color], done: { [weak self] selectedIndex in
+                                    self?.controller?.sort(selectedIndex)
+                                    self?.currentSortIndex = selectedIndex
+                                }, cancel: {})
     }
 }
 

SWDestinyTradesTests/Doubles/PopoverMenuManagerSpy.swift

@@ -0,0 +1,31 @@
+//
+//  PopoverMenuManagerSpy.swift
+//  SWDestinyTradesTests
+//
+//  Created by Diogo Autilio on 23/03/24.
+//  Copyright © 2024 Diogo Autilio. All rights reserved.
+//
+
+import Foundation
+import UIKit
+
+@testable import SWDestinyTrades
+
+final class PopoverMenuManagerSpy: PopoverMenuManagerType {
+
+    private(set) var didCallShowPopoverMenuCount = 0
+    var executeDoneBlock = false
+    var executeCancelBlock = false
+    func showPopoverMenu(forEvent event: UIEvent,
+                         with menuArray: [String],
+                         done: ((NSInteger) -> Void)?,
+                         cancel: (() -> Void)?) {
+        didCallShowPopoverMenuCount += 1
+        if executeDoneBlock {
+            done?(0)
+        }
+        if executeCancelBlock {
+            cancel?()
+        }
+    }
+}

SWDestinyTradesTests/Screens/UserCollection/Presenter/UserCollectionPresenterTests.swift

@@ -18,15 +18,18 @@ final class UserCollectionPresenterTests: XCTestCase {
     private var controller: UserCollectionViewControllerSpy!
     private var navigator: UserCollectionNavigator!
     private var database: RealmDatabase?
+    private var manager: PopoverMenuManagerSpy!
 
     override func setUp() {
         super.setUp()
         controller = UserCollectionViewControllerSpy()
         navigationController = UINavigationControllerMock(rootViewController: controller)
         database = RealmDatabaseHelper.createMemoryDatabase(identifier: #function)
+        manager = PopoverMenuManagerSpy()
         navigator = UserCollectionNavigator(controller)
         sut = UserCollectionPresenter(controller: controller,
                                       dispatchQueue: DispatchQueueSpy(),
+                                      manager: manager,
                                       database: database,
                                       navigator: navigator)
     }
@@ -71,7 +74,22 @@ final class UserCollectionPresenterTests: XCTestCase {
         let sortButton = barButtonItems?.0?[0]
         _ = sortButton?.target?.perform(sortButton!.action, with: nil)
 
-        // XCTAssertTrue(navigationController.currentPushedViewController is AddCardViewController)
+        XCTAssertEqual(manager.didCallShowPopoverMenuCount, 1)
+    }
+
+    func test_sort_selecting_item() {
+        manager.executeDoneBlock = true
+
+        var barButtonItems: ([UIBarButtonItem]?, [UIBarButtonItem]?)?
+        sut.setupNavigationItems { leftItems, rightItems in
+            barButtonItems = (leftItems, rightItems)
+        }
+        let sortButton = barButtonItems?.0?[0]
+        _ = sortButton?.target?.perform(sortButton!.action, with: nil)
+
+        XCTAssertEqual(manager.didCallShowPopoverMenuCount, 1)
+        XCTAssertEqual(controller.didCallSort.count, 1)
+        XCTAssertEqual(controller.didCallSort[0], 0)
     }
 
     // MARK: - Test addCard