Enhance the log for failures when reading or parsing the fee_estimates.dat file #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a try-catch block for error handling in the TxConfirmStats::Read function.
Update fees.cpp [try-catch]
|
What error didn't get caught? |
|
Although the check on fileDecay ensures the integrity of the data by confirming that it is between 0 (no decay) and 1 (full decay), there remains a potential issue with data corruption or a software bug. The try-catch block has the benefit of logging any potential errors. |
|
Neat. Seems like it would cut out uncertainties.Sent from my iPhoneOn Mar 28, 2024, at 10:27 PM, Skylar Loomis ***@***.***> wrote:
Although the check on fileDecay ensures the integrity of the data by confirming that it is between 0 (no decay) and 1 (full decay), there remains a potential issue with data corruption, modification, or a software bug.
The try-catch block ensures that the data integrity adheres to specific expectations regarding its values and structure. Additionally, it has the added benefit of logging out any potential errors.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Okay. An overall try-catch already is implemented in the calling code: Line 926 in 6c0095b If you're looking to enrich the logged message (I'd support that), it should be done in that catch block instead. |
patricklodder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a try-catch block for error handling in the TxConfirmStats::Read function.