Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate arbic #3439

Open
wants to merge 8 commits into
base: 1.15.0-dev
Choose a base branch
from
Open

Translate arbic #3439

wants to merge 8 commits into from

Conversation

Bestmeer
Copy link

modified few translations and added some, still more translation is required, if all good let me know so i can do more

@patricklodder patricklodder changed the base branch from master to 1.14.7-dev February 21, 2024 21:53
@patricklodder patricklodder added this to the 1.14.7 milestone Feb 21, 2024
@patricklodder patricklodder requested a review from a team February 21, 2024 21:54
@patricklodder patricklodder added this to 🚀 needs review in Review & merge board Feb 21, 2024
@patricklodder patricklodder mentioned this pull request Feb 21, 2024
43 tasks
src/qt/locale/bitcoin_ar.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_ar.ts Outdated Show resolved Hide resolved
src/qt/locale/bitcoin_ar.ts Outdated Show resolved Hide resolved
Ar Ts 24022024
@Bestmeer Bestmeer changed the base branch from 1.14.7-dev to master February 24, 2024 18:00
@patricklodder patricklodder changed the base branch from master to 1.14.7-dev February 24, 2024 18:01
@patricklodder
Copy link
Member

patricklodder commented Feb 25, 2024

Alright. So there's an issue that the linter doesn't catch with numerus. When we delete the numerus form in favor of a single form, the compilation breaks. I'll add that to the linter at a later time.

Also, every time I try to comment on specific lines, my browser crashes, so I need to do textual instruction, sorry.

There are issues that can be resolved by:

  • remove numerus="yes" from line 1017
  • add %n to the translation at line 1019
  • remove numerus="yes" from line 1021
  • remove numerus="yes" from line 1876, 1880, 1884, 1888, 1892 and 1896
  • remove numerus="yes" from line 3117
  • remove numerus="yes" from line 3149
  • remove numerus="yes" from line 3146
  • remove numerus="yes" from line 3275

And then all should be good

If this doesn't work for you, I can patch it for you (I have the patch because I had to go through it all)

@Bestmeer
Copy link
Author

Thanks Patrick, updated

@Bestmeer
Copy link
Author

Please feel free to amend any thing

@patricklodder

This comment was marked as resolved.

@Bestmeer
Copy link
Author

Thanks yea my bad because I add 2 new translations

Updated

@patricklodder
Copy link
Member

Added help wanted: this could use a sanity check by a native speaker.

@Bestmeer
Copy link
Author

Due to lack of reviews, if I may suggest that anybody can pick lines in Arabic and translate them to English with google translate and do sanity check

@patricklodder
Copy link
Member

No worries. If it doesn't make it in, we simply rehang it to the next release 1-on-1 and get a relaxed timeframe to get it in. No reviewers generally means we're either not reaching the people that care, or there aren't enough people that care in general yet. That's something that can be worked on.

@patricklodder
Copy link
Member

Let's move this one to the next release. This buys time to get a good review in.

@patricklodder patricklodder removed this from the 1.14.7 milestone Feb 27, 2024
@patricklodder patricklodder changed the base branch from 1.14.7-dev to 1.15.0-dev February 28, 2024 19:29
</message>
<message>
<source>Be careful! Do not blindly trust anyone that tells you to add their node.</source>
<translation type="unfinished"></translation>
<translation>احرص! لا تثق بشكل أعمى بأي شخص يطلب منك إضافة العقدة الخاصة به</translation>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

أحترس! لاتثق بشكل أعمى بأي شخص يطلب منك إضافه العقد الخاص به .

Copy link

@pythonmtl pythonmtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful! Do not blindly trust anyone that tells you to add their node.
حذاري! لا تثق بشكل أعمى بأي شخص يطلب منك إضافة العقد الخاص به .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Review & merge board
🚀 needs review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants