Add extra configuration file to persist RPC-set features #3328
Conversation
This gives us a place to add a textual representation of several runtime-set configuration options, such as dust fees and locked unspent transactions.
This code needs access to the wallet (even if it's not running or enabled) and has to write wallet data before the wallet goes away. It's also better if it uses C++ strings everywhere, so get rid of the C-style printing in favor of functions that already exist. One nit: adding more header information to `src/util.h` increases coupling between these files, so perhaps this code is better off somewhere other than `src/util.cpp`?
|
Sorry, pushed the first version of this one commit too early. This at least compiles locally. |
|
I can reproduce this compilation error now locally, so I'll continue working on the code, but I think the design questions remain. |
To not mix wallet and node parameters, would it make sense to create a new data type for the wallet and store this simply inside wallet.dat? That way you only have to backup 1 file still when it comes to your funds, and this will be much easier to port to 1.21 where we'll have both bdb and sqlite wallets. If you'd agree that to be a better solution for that particular problem, and afaik the other RPC calls aren't wallet related, I have no problem with writing an additional file.
Since we're overriding values that can also be set in dogecoin.conf, I would make this a binary file rather than a text file (just reuse leveldb?), much like how the .plist (and I think some registry keys in Windows?) can persist some of the settings in Qt and have higher precedence over the conf. |
This begins to address a feature request in #3206. I'm creating it as a draft for now, because we should have make some design decisions before going further.
Current flaws:
However, in the spirit of debating working code (and in the interest of not replicating uninspectable binary .dat files for important options like these), it's worth at least a draft.