Added BIP39 graphical interface #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to rebase this on top of the new gui code which in a open pr? |
|
Yep it is possible
…On Wed, Sep 11, 2019, 12:00 AM Akshay CM ***@***.***> wrote:
Is it possible to rebase this on top of the new gui code which in a open
pr?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/dogecash/dogecash/pull/13?email_source=notifications&email_token=AHRTWZGZLBUZBSOD2D44UZ3QJCCP5A5CNFSM4IVO2TB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6NLNPQ#issuecomment-530233022>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHRTWZERO6XXJATGNRVLXQLQJCCP5ANCNFSM4IVO2TBQ>
.
|
|
let me know when its added on the new gui instead of the old one |
|
Lets check on these file conflicts and once moved to new Ui we can merge this on over. |
|
Sure
Liquid369 <notifications@github.com> schrieb am Mo., 7. Okt. 2019, 7:31
vorm.:
… Lets check on these file conflicts and once moved to new Ui we can merge
this on over.
Looks good Kolby, great work. As the new ui is going to hinge on the next
release alongside HD wallets, we agree its imperative to have this as
otherwise renders the HD wallet useless. Let us know when it is ready for
new ui!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/dogecash/dogecash/pull/13?email_source=notifications&email_token=AHRTWZBHJ5RRFQPARHCDA6TQNM22RA5CNFSM4IVO2TB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQKY4Y#issuecomment-539012211>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHRTWZG6Z22AGIUOCOWOM7LQNM22RANCNFSM4IVO2TBQ>
.
|
|
Are we still working on this? Just wondering otherwise I will try porting it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did I make a PR to add this code? Without a graphical interface, the implementation would be nothing more than more lines added to the codebase. The reason for this is because BIP39 only adds value if it is useable. With this interface, you will be able to set up the mnemonic through a graphical interface which will make it more accessible to a wider populace.
Some screenshots of it. Some of the pages have place holder text were you the team can remove it or add the text you seem fitting.
This is the recover page
This is the new wallet page
Drag and drop sorting area
