Merge pull request #2 from doganoo/session

session improvement
doganoo · Oct 18, 2020 · 449dfdd · 449dfdd
2 parents ca23ccc + 21cceff
commit 449dfdd
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/HTTP/Session.php b/src/HTTP/Session.php
@@ -64,7 +64,15 @@ public function remove(string $index): void {
      * @return string|null
      */
     public function get(string $index, $default = null): ?string {
-        return $_SESSION[$index] ?? $default;
+        if (isset($_SESSION[$index])) {
+            return $_SESSION[$index];
+        }
+
+        if (null === $default) {
+            return null;
+        }
+
+        return $default;
     }
 
     /**
@@ -91,7 +99,7 @@ public function regenerateSessionId(bool $deleteOldSession = true): bool {
      * @return bool
      */
     public function isStarted(): bool {
-        return false === (session_id() === '' || !isset ($_SESSION));
+        return session_status() === PHP_SESSION_ACTIVE;
     }
 
     /**