New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide/show elements correctly when search is empty #141

Open

dule wants to merge 2 commits into documentcloud:master from benbria:el-display-fixes

dule commented Sep 25, 2014

This fixes:

Hiding the placeholder when there's input in the search box
Hiding the cancel/clear button when the search box is empty

This includes the changes of #134 as both relies on the same check if the search box is truly empty and #134 is yet to be merged.

goffrie and others added 2 commits

March 25, 2014 10:39


          Don't show the placeholder when there's entered text.

b332b9f

Otherwise the text overlaps with the placeholder.


          Hide cancel(clear) button when search box empty

a7f50f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment