This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Move DocumentCloud account management into Circlet #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s omniauth Adds circlet integration, cleans up previous omniauth
…s omniauth Adds circlet integration, cleans up previous omniauth
The `common/bootstrap` partial wasn’t being substantively used by anything besides the workspace template, which made the debug chain unnecessarily long. Consolidated its contents into the workspace template (except for a small bit used by the home template). Also disarm some hashrockets.
This might should be sussed out from the omniauth secrets, but for now…
This shoulda been part of 2e0fad9
# Conflicts: # Gemfile.lock # config/document_cloud.yml
This was moved to the workspace controller already
This’ll be handled with an on-page message soon, so that visitors can keep muscling through if they desire.
* Organize nav items better * Use mostly the same nav for users and randos * Add new user menu site-wide
* Firewall headers for style encapsulation * Use custom workspace header
* Disarm hashrockets * Convert some strings to symbols * Use consistent whitespace formatting around params, parens, etc. * Align assignments sensible * Remove outdated opening comment
TODO: Convert all this to use flexbox. Until then…
* Create route for switching current membership/organization * Remove unused OrgSwitcher Backbone View
Also optimize `dc.model.Account.currentOrganization()` and add `dc.model.Account.currentMembership()`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.