Docsplit images command - Added the ability to specify the page number delimiter via a command line option #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter via command line option
| @@ -101,6 +101,9 @@ def parse_options | |||
| opts.on('-r', '--rolling', 'generate images from each previous image') do |r| | |||
| @options[:rolling] = true | |||
| end | |||
| opts.on('--delimiter [DELIMITER]', 'set page number delimiter (eg: _, -, -Page-...)') do |d| | |||
| @options[:delimiter] = d.tr('^','') | |||
There was a problem hiding this comment.
In order to have your delimiter start with a dash, you need to escape it with the '^' character. So, we need to strip the '^' before passing it to @options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using docsplit images to split a pdf into a series of images (e.g. foo.pdf --> foo_1.jpg, foo_2.jpg, ...), the user may want the ability to specify the page number delimiter. For example, instead of always using an underscore ('_'), the user may want to use a dash ('-') or something more complicated (e.g. foo.pdf --> foo-page-1.pdf, foo-page-2, ...).