New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added teams url under a team name in teams section #951
Conversation
@sumitbishti is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
Hey There! and thank you for opening this pull request! 📝👋🏼 We require pull request titles to follow the Conventional Commits Spec and it looks like your proposed title needs to be adjusted. Details:
|
WalkthroughThe change involves a simple alteration in the codebase where the same set of entities are re-exported in Changes
Assessment against linked issues
In conclusion, the current changes do not address the primary objectives outlined in the linked issue #943, which seeks to add differentiators for teams in the profile dropdown. The modification in Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
You should be able to do all this with just css, no need for state or changes to {teams.map((team) => (
<DropdownMenuItem asChild key={team.id}>
<Link href={formatRedirectUrlOnSwitch(team.url)} className="group">
<AvatarWithText
avatarFallback={formatAvatarFallback(team.name)}
primaryText={team.name}
secondaryText={
<>
<span className="opacity group-hover:hidden">
{formatSecondaryAvatarText(team)}
</span>
<span className="opacity-0 group-hover:opacity-100">{`/t/${team.url}`}</span>
</>
}
rightSideComponent={
isPathTeamUrl(team.url) && (
<CheckCircle2 className="ml-auto fill-black text-white dark:fill-white dark:text-black" />
)
}
/>
</Link>
</DropdownMenuItem>
))} Also would probably be nice to disable this feature if there's only 1 team. |
i think we should keep it. It would be more consistent that way. |
The goal of this feature is to distinguish between duplicate names for teams, which is unlikely in the first place. We expect the majority of people with teams to generally will have 1 team, and if they had more it would be unlikely to have duplicate names. So it doesn't really make sense to have this for one team. |
Hey @sumitbishti there doesn't appear to be any changes in this PR, which is fine If you don't feel like proceeding we can close this? |
No actually there are changes. I'll push them shortly. I thought i had pushed them! My bad. |
fixes: #943
Video Link: https://www.loom.com/share/35328504cf3f46e9be78bd485252e8dc?sid=1f309776-8b52-4af4-b86b-652b762fef5b
Summary by CodeRabbit