New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove document on go back click on step 1 #910
Conversation
Invoke onBackStep on "go back" click and conditionally render go back label
@prajwalkulkarni is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
Hey There! and thank you for opening this pull request! 📝👋🏼 We require pull request titles to follow the Conventional Commits Spec and it looks like your proposed title needs to be adjusted. Details:
|
Important Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Hey there, it looks like you haven't accepted our contributor license agreement yet. In order for us to accept your pull request we ask that you please fill out the CLA: |
Done! |
goBackLabel={ | ||
currentStep === 1 && typeof documentFlow.onBackStep === 'function' | ||
? 'Remove' | ||
: undefined | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't work since it would also affect the main webapp where the document wouldn't be removed 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a global lookup of where all AddFieldsFormPartial
is used and it looks like it is used only in singleplayermode and edit-document.tsx
which is a part of main webapp dashboard. The property documentFlow.fields
in edit-document.tsx
doesn't have the onBackStep
property implemented, meaning typeof documentFlow.onBackStep
would be falsy, thereby the default fallback string would be rendered (Please correct me If I'm wrong here). Nonetheless, I've made the changes by adding an additional optional prop to the AddFieldsFormPartial
component to keep it future-proof. Kindly check.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lgtm 💚 |
💫 Changelog
⭐ Fixes #903
⭐ Invoke
onBackStep
on "Go Back" click and conditionally render Go back label string.