Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an example demo of the issue, looking for suggestions and discussions.
Currently any open dialogs nested into a table column will close when the page is focused due to us running
router.refresh()
wheneveronFocus
callback is triggered.This appears to be caused by the columns prop getting replaced, which causes the columns to get rerendered.
There are a few ways to go about this, this commit is a dirty example which prevents this from happening.
Another option is to add a stableColumn prop, which we then assume never change so we use the initial value only.