Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition on Ascii String for SQL Server #6389

Open
wants to merge 8 commits into
base: 3.8.x
Choose a base branch
from
Open

Fix condition on Ascii String for SQL Server #6389

wants to merge 8 commits into from

Conversation

Yovach
Copy link

@Yovach Yovach commented May 6, 2024 •
edited

Q A
Type bug
Fixed issues #6245

Summary

This MR fixes a condition on SQL Server where fixed is always defined as true or false so return sprintf('VARCHAR(%d)', $length ?? 255); is always ignored.

@greg0ire greg0ire added the Bug label May 6, 2024
@SenseException
Copy link
Member

Thanks for your pull request. Please create a test that covers your fix for SQL Server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yovach @SenseException @greg0ire