Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save a few bucks on circle ci artifacts #5885

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented May 14, 2024

Description
See dockstore/dockstore-ui2#1970 first
I think these are only used for the UI2 build, strip them out and slowly save some money on circle ci as they age out over 30 days
(we still use other artifacts in general for guiding our division of tests into parallel builds)

Review Instructions
See if builds start to have fewer artifacts attached to their unit_test jobs

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5713

Security and Privacy

None

  • Security and Privacy assessed

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this May 14, 2024
@denis-yuen denis-yuen changed the title save a few bucks save a few bucks on circle ci artifacts May 14, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.82%. Comparing base (142f581) to head (88a0d06).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5885      +/-   ##
=============================================
- Coverage      73.83%   73.82%   -0.02%     
+ Complexity      5265     5264       -1     
=============================================
  Files            371      371              
  Lines          19211    19211              
  Branches        2012     2012              
=============================================
- Hits           14184    14182       -2     
- Misses          4070     4072       +2     
  Partials         957      957              
Flag Coverage Δ
bitbuckettests 27.12% <ø> (ø)
integrationtests 58.43% <ø> (ø)
languageparsingtests 11.07% <ø> (ø)
localstacktests 21.68% <ø> (ø)
toolintegrationtests 30.47% <ø> (ø)
unit-tests_and_non-confidential-tests 28.45% <ø> (ø)
workflowintegrationtests 38.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen marked this pull request as ready for review May 15, 2024 15:26
@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye, svonworl, coverbeck and kathy-t and removed request for a team May 15, 2024 15:26
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@denis-yuen denis-yuen merged commit 0430bbe into develop May 16, 2024
18 checks passed
@denis-yuen denis-yuen deleted the feature/strip_artifacts branch May 16, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants