Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6420: Add new health check names to endpoint allowableValues #5883

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented May 13, 2024

Description
This PR adds liquibaseLock and elasticSearchConsistency to the list of allowed values for the include parameter of the health check endpoint. It also removes the obsolete @ApiParam annotation.

Review Instructions
Confirm that the new values appear in openapi.yaml.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6420

Security and Privacy

No concerns.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (142f581) to head (b698290).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5883      +/-   ##
=============================================
- Coverage      73.83%   73.81%   -0.02%     
+ Complexity      5265     5263       -2     
=============================================
  Files            371      371              
  Lines          19211    19211              
  Branches        2012     2012              
=============================================
- Hits           14184    14181       -3     
- Misses          4070     4072       +2     
- Partials         957      958       +1     
Flag Coverage Δ
bitbuckettests 27.11% <ø> (-0.01%) ⬇️
integrationtests 58.43% <ø> (ø)
languageparsingtests 11.07% <ø> (ø)
localstacktests 21.68% <ø> (ø)
toolintegrationtests 30.47% <ø> (ø)
unit-tests_and_non-confidential-tests 28.33% <ø> (-0.12%) ⬇️
workflowintegrationtests 38.65% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl merged commit b769e72 into develop May 23, 2024
18 checks passed
@svonworl svonworl deleted the feature/seab-6420/modify-endpoint-description-for-new-health-checks branch May 23, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants