Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the dropwizard things #5804

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Feb 9, 2024

Description
Iterate dockstore to 1.16 and update dropwizard and it's supporting components

Review Instructions
Builds should pass

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6239

Security and Privacy

No real change aside from transitive improvements

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Feb 9, 2024
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.51%. Comparing base (ab664cb) to head (65dfa85).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5804      +/-   ##
=============================================
- Coverage      74.52%   74.51%   -0.02%     
+ Complexity      5260     5257       -3     
=============================================
  Files            368      367       -1     
  Lines          19017    19013       -4     
  Branches        2024     2024              
=============================================
- Hits           14173    14168       -5     
  Misses          3883     3883              
- Partials         961      962       +1     
Flag Coverage Δ
bitbuckettests 27.13% <ø> (+<0.01%) ⬆️
integrationtests 58.51% <ø> (-0.01%) ⬇️
languageparsingtests 11.00% <ø> (-0.02%) ⬇️
localstacktests 21.61% <ø> (+<0.01%) ⬆️
toolintegrationtests 30.50% <ø> (+<0.01%) ⬆️
unit-tests_and_non-confidential-tests 28.93% <ø> (-0.02%) ⬇️
workflowintegrationtests 38.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen
Copy link
Member Author

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@denis-yuen
Copy link
Member Author

Note to self: updated to 4.0.7, but need to test without forced jersey override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant