Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overrides-gitpod for solr support #1679

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

froboy
Copy link
Contributor

@froboy froboy commented May 9, 2022

fixes #1678 with great thanks to @sean-e-dietrich in Slack

To test:

  • Set up a gitpod project with Solr
  • Check the Remote Explorer
  • Observe port 8983 has a service available
  • Click "Open Browser" and observe the Solr UI is accessible.
    docsal_solr

Copy link
Member

@sean-e-dietrich sean-e-dietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I can see with this is that if solr does not exist this will throw some errors and the whole stack won't start. Ideally we would turn this into part of the documentation as Solr won't be the only thing we'd need to access the web interface for.

@froboy
Copy link
Contributor Author

froboy commented May 10, 2022

@sean-e-dietrich that makes sense. I've been thinking on it and I'm wondering where it'd go though. Is there support for other docksal-*.[env|yml] files similar to docksal-local.[env|yml]? So like, we'd only want this to load in a gitpod environment, so it'd need to be in something like docksal-gitpod.yml?

@froboy
Copy link
Contributor Author

froboy commented May 10, 2022

I tried creating .docksal/stacks/overrides-gitpod.yml in my project and that didn't take. It seems like #1558 might be related.

Instead, I'm thinking writing to .docksal/docksal-local.yml in the gitpod init process might be the best way to get that config into the environment.

tee -a ./.docksal/docksal-local.yml <<EOF
services:
  solr:
    ports:
      - "8983:8983"
    labels:
      - io.docksal.virtual-host=8983-${GITPOD_WORKSPACE_ID}.${GITPOD_WORKSPACE_CLUSTER_HOST}
EOF

depending on the complexity of your setup, a few options come to mind:

  • putting this directly into the .gitpod.yml init task
  • a fin command that gets run in the Gitpod init
  • a file like gitpod-docksal-local.yml in .docksal/files that gets copied or appended to .docksal/docksal-local.yml in the gitpod init.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solr UI can't be reached in GitPod
2 participants