Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compose-go 1.1.0 #9219

Merged
merged 1 commit into from Mar 1, 2022
Merged

Conversation

ulyssessouza
Copy link
Contributor

What I did
Bump compose-go 1.1.0

Related issue
Resolves #745

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
@ulyssessouza ulyssessouza merged commit 327a1bb into docker:v2 Mar 1, 2022
@glensc
Copy link

glensc commented Mar 1, 2022

Wait, wait? "Proposal: make project-name persistent, #745" got implemented with this?! 🎉

@glours
Copy link
Contributor

glours commented Mar 1, 2022

@glensc yep 👍

@glensc
Copy link

glensc commented Mar 1, 2022

Looks feels like very secretive, not even references in pull requests or changelogs with descriptions.

however, found the pr with changes:

and then description of the changes:

@glours
Copy link
Contributor

glours commented Mar 1, 2022

We can't say it was secretive 😅 , the Compose Specification is public and the #745 where mentioned in this Compose Spec update PR
Screenshot 2022-03-01 at 16 26 27

@glensc
Copy link

glensc commented Mar 1, 2022

I tried to say it feels secretive, as #745 was closed automatically, and it refers to #9219, which has some technical description, not seemingly related to the problem at hand. could the original issue be closed by accident I was wondering?

so I had to find what that compose-go is, and their 1.1.0 release notes also said nothing, and it also has no changelog, so had to visit their commits to find a related pull request ...

What would feel better is a post there saying something along "Hooray, we have released docker-compose 1.32 (includes docker-go 1.1.0) with the support of "name", it will be available on 1st of April and if you use docker desktop then it will be bundled with next update"

:)

@glours
Copy link
Contributor

glours commented Mar 1, 2022

Ok thanks for your feedback, I updated the compose-go release notes
And we didn't release a new version of Compose right now 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: make project-name persistent.
4 participants