Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_name top-level config key #6815

Closed
wants to merge 7 commits into from
Closed

Conversation

pipe01
Copy link

@pipe01 pipe01 commented Jul 24, 2019

Resolves #745

I suppose the JSON schema change should go on a different version but I'm unsure about how to do that.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:pipe01/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Felipe Martinez <pipernene@gmail.com>
@pipe01 pipe01 marked this pull request as ready for review July 24, 2019 14:31
Signed-off-by: Felipe Martinez <pipernene@gmail.com>
Signed-off-by: Felipe Martinez <pipernene@gmail.com>
@pipe01 pipe01 changed the title Add project_data top-level config key Add project_name top-level config key Jul 24, 2019
Signed-off-by: Felipe Martinez <pipernene@gmail.com>
Signed-off-by: Felipe Martinez <pipernene@gmail.com>
Signed-off-by: Felipe Martinez <pipernene@gmail.com>
Signed-off-by: Felipe Martinez <pipernene@gmail.com>
@terjebraten-certua
Copy link

Duplicate of #3118 and #5369

@ulyssessouza
Copy link
Contributor

As commented in #6815 (comment), this is an already refused feature.

@artnaseef
Copy link

Why is this feature "refused"?

@pipe01
Copy link
Author

pipe01 commented Sep 12, 2019

No clue, it's extremely useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: make project-name persistent.
5 participants