Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to use a custom progress printer for the build progress output #11624

Closed
wants to merge 47 commits into from
Closed

Add an option to use a custom progress printer for the build progress output #11624

wants to merge 47 commits into from

Conversation

rarguelloF
Copy link

@rarguelloF rarguelloF commented Mar 15, 2024 •
edited

please ignore this PR, I reopened here #11625

rarguelloF and others added 30 commits February 6, 2024 17:18
@rarguelloF
add an option to use a custom progress printer for the build progress
5fb0b24
@jhrotko @rarguelloF
Fix canonical container name
76b720f 
Signed-off-by: jhrotko <joana.hrotko@docker.com>
@crazy-max @rarguelloF
ci(deps): replace buildkit to fix fsutil issues on Windows (docker#11426
d6a8116 
)
@milas @rarguelloF
chore(e2e): fix flaky test & standalone behavior (docker#11382)
eab44a3
@ndeloof @rarguelloF
Fix load .env from project directory when project file is set by COMP…
c41f3a9 
…OSE_FILE

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@dependabot @rarguelloF
build(deps): bump github.com/docker/cli
a34a367 
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 25.0.1+incompatible to 25.0.2+incompatible.
- [Commits](docker/cli@v25.0.1...v25.0.2)

---
updated-dependencies:
- dependency-name: github.com/docker/cli
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@ndeloof @rarguelloF
CI: docker engine version matrix
0a1f22d 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
bump compose-go to v2.0.0-rc.4
f1c01ef 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@laurazard @rarguelloF
Include all networks in ContainerCreate call if API >= 1.44
2259da0 
Previously, we included the container's primary network in the
ContainerCreate API call, and then connected the created container
to each extra network one-by-one, by calling NetworkConnect.

However, starting API version 1.44, the ContainerCreate endpoint now
takes multiple EndpointsConfigs, allowing us to just include all the
network configurations there and skip connecting the container to each
extra network separately.

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@milas @rarguelloF
chore(load): ensure context passed to load
240f15b 
This wasn't always getting passed, so adding it to the wrapper
function where it'll pass the `WithContext()` loader method at
the last moment.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas @rarguelloF
feat(tracing): add project hash attr
54ba387 
Hash the project config and add it as an attribute. This can be
used to group multiple spans.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@dependabot @rarguelloF
build(deps): bump github.com/opencontainers/image-spec
0f10e17 
Bumps [github.com/opencontainers/image-spec](https://github.com/opencontainers/image-spec) from 1.1.0-rc5 to 1.1.0-rc6.
- [Release notes](https://github.com/opencontainers/image-spec/releases)
- [Changelog](https://github.com/opencontainers/image-spec/blob/main/RELEASES.md)
- [Commits](opencontainers/image-spec@v1.1.0-rc5...v1.1.0-rc6)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/image-spec
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@jhrotko @rarguelloF
Add OTEL specs: build, depends_on, capabilities (gpu/tpu)
0ac1318 
Signed-off-by: jhrotko <joana.hrotko@docker.com>
@1arp @rarguelloF
pass All option to backend api.Service when length statuses is not eq…
18e8245 
…ual to zero

Signed-off-by: 1arp <dekhijaegi@gmail.com>
@ndeloof @rarguelloF
ci(deps): bump docker/cli to v25.0.3 (docker#11481)
7825cc2 
https://github.com/docker/cli/releases/tag/v25.0.3
https://github.com/moby/moby/releases/tag/v25.0.3
@ndeloof @rarguelloF
fix deadlock collecting large logs
69c916a 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@jhrotko @rarguelloF
Use listener for file metadata
5a587b4 
Signed-off-by: jhrotko <joana.hrotko@docker.com>
@PiotrDabrowskey @rarguelloF
docs: unify no trailing dots in docstrings and help (docker#11301)
22e24bc
@milas @rarguelloF
chore(watch): remove old docker cp implementation
a41fc58 
This has not been the default for quite a while and required
setting an environment variable to revert back.

The tar implementation is more performant and addresses several
edge cases with the original `docker cp` version, so it's time
to fully retire it.

The scaffolding for multiple sync implementations remains to
support future experimentation here.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@dvdksn @rarguelloF
docs: update cli reference link
ba30ec9 
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@ndeloof @rarguelloF
use listeners to collect include metrics
070d515 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
discard stdout for laaarge log test
4257567 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
sort containers to optimize scale down
8f9261a 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@laurazard @rarguelloF
ci: bump engine version to 25.0.3
5628053 
changes: https://github.com/moby/moby/releases/tag/v25.0.3

(Hopefully, this fixes some networking flakyness)

Signed-off-by: Laura Brehm <laurabrehm@hey.com>
@rarguelloF
Issue-11374: Modified compose up command to respect COMPOSE_REMOVE_OR…
75343a5 
…PHANS environment variable

Signed-off-by: Gautham Hullikunte <46633282+batcity@users.noreply.github.com>
Signed-off-by: Gautham Hullikunte <gautham@Gauthams-MacBook-Pro.local>
@ndeloof @rarguelloF
when ran with ANSI disabled, force progress=plain
f74ee6d 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours @rarguelloF
pass QuietOption when starting dependencies from run command
5d11902 
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours @rarguelloF
add support of QuietOption to create command
dc6d7dd 
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours @rarguelloF
use an dedicated compose file --quiet-pull e2e test
3989aa1 
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours @rarguelloF
bump compose-go to version v2.0.0-rc.8
3a99e20 
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours and others added 17 commits March 15, 2024 14:16
@glours @rarguelloF
Add a fallback check of Watch pid on Windows
476dbee 
False positives were detected when checking the previous watch process state

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@ndeloof @rarguelloF
get log to manage attach
531f0f6 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@jhrotko @rarguelloF
remove docker cli step in ci.yml
a2803e9 
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
@ndeloof @rarguelloF
restore support for config --no-interpolate
895f451 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
move code into small functions for better readability
96de87a 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
introduce --watch
d05c176 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
avoid duplicated "xx exited with code 0" message
fcef7a9 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
make code simpler
ba5792e 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@jhrotko @rarguelloF
Add test summary for test jobs in ci
cd93bac 
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
@milas @rarguelloF
ci(deps): bump moby/moby & docker/cli to v25.0.4 (docker#11566)
5a1c495
@milas @rarguelloF
chore(deps): upgrade go to 1.21.8 (docker#11578)
0e527d4
@milas @rarguelloF
feat(desktop): add Docker Desktop detection and client skeleton (dock…
7b7f6a0 
…er#11593)
@ndeloof @rarguelloF
only use ToModel when --no-interpolate is set
5a8c9c0 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof @rarguelloF
fix TestBuildPlatformsWithCorrectBuildxConfig
bf30287 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@oandrew @rarguelloF
services shell completion bugfix
ea75fd7 
Signed-off-by: Andrew Onyshchuk <andryk.rv@gmail.com>
@ndeloof @rarguelloF
Bump compose-go v2.0.0
11ac649 
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@rarguelloF
add an option to use a custom progress printer for the build progress…
bff6d36 
… output

Signed-off-by: Rodrigo Arguello <rarguellof91@gmail.com>
@rarguelloF rarguelloF force-pushed the rarguelloF/build-progress-printer branch from d39bc45 to bff6d36 Compare March 15, 2024 13:23
@rarguelloF rarguelloF marked this pull request as draft March 15, 2024 13:25
@rarguelloF rarguelloF closed this Mar 15, 2024
@rarguelloF rarguelloF deleted the rarguelloF/build-progress-printer branch March 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet