fix race condition, waiting for containers when one exit #10725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
exit_race_condition
branch
from
e15772a
to
123587b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10725 +/- ##
==========================================
+ Coverage 58.94% 58.99% +0.04%
==========================================
Files 112 112
Lines 9749 9752 +3
==========================================
+ Hits 5747 5753 +6
+ Misses 3413 3410 -3
Partials 589 589
☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
exit_race_condition
branch
from
123587b
to
853c219
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
fho
reviewed
Jun 20, 2023
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
exit_race_condition
branch
from
853c219
to
0de121f
Compare
milas
approved these changes
Jun 20, 2023
|
Hello there! It took me 3 days of troubleshooting/purging/reinstalling docker-desktop to finally find this issue because compose also stopped throwing error messages which could have shortened my odyssey: compose-not-responding+stuck-forever.mp4@ndeloof Could we please somehow trigger a release of Docker Desktop whenever a new Compose version is released so that always recent versions get shipped?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
as a container exits with error, we must cancel but the goroutine waiting for expected container to be started used to get stuck waiting. Need to stop waiting when context is cancelled
Related issue
fixes #10707
fixes #10718
(not mandatory) A picture of a cute animal, if possible in relation to what you did