Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig build fails in folders with names containing capital letters #655

Closed
nonsensery opened this issue Nov 17, 2014 · 9 comments
Closed

Fig build fails in folders with names containing capital letters #655

nonsensery opened this issue Nov 17, 2014 · 9 comments

Comments

@nonsensery
Copy link

Steps to Reproduce

  1. Create a folder named "FigTest".

  2. Add a Dockerfile:

    FROM ubuntu:14.04
    
  3. Add a fig.yml:

    app:
      build: .
    
  4. Run fig build.

Expected Result

A container image would be built from the current directory.

Actual Result

Operation fails with an error from Docker: "Invalid repository name (FigTest_app), only [a-z0-9-_.] are allowed"

Discussion

It looks like Docker image names do not allow uppercase letters. Fig creates the image name from the name of the directory, with some processing to remove invalid characters, but it does not convert uppercase letters to lowercase.

@aanand
Copy link

aanand commented Nov 18, 2014

Yep, see #541.

@totallymike
Copy link

As a simple workaround, would it make sense to allow the --project-name flag be set in the fig.yml file? The failure happens in the default case because Fig tries to name its containers based on the directory name, but if we can store a different name, that would be helpful (and save me from typing fig -p foobar run ...) each time.

@dnephin
Copy link

dnephin commented Dec 3, 2014

Yes, that would be awesome, see #45

I'm just waiting on the docker format to stabilize, then I'd like to add support for it to fig.

@lwansbrough
Copy link

Update on this? Kind of annoying! :)

@shihshen
Copy link

@lwansbrough
Indeed.

@sethherr
Copy link

+1 🍰

@danroberts
Copy link

+1 Also, apparently if you change the name of the folder from capital to lowercase there are times were fig still chooses the capital version for some reason. That part may be unique to my setup, but it's super annoying.

@aanand
Copy link

aanand commented Feb 24, 2015

Closed by #568

@aanand aanand closed this as completed Feb 24, 2015
@aanand
Copy link

aanand commented Feb 24, 2015

Anyone experiencing this issue is encouraged to give Compose 1.1.0 RC2 a try! https://github.com/docker/fig/releases/tag/1.1.0-rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants