Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for uppercase or underscores or any separator in container names #941

Closed
Vrakfall opened this issue Feb 10, 2015 · 6 comments
Closed

Comments

@Vrakfall
Copy link

I saw 1 or 2 issues talking about supporting dashes or dots in container names and some arguments why it cannot be done for now but I found nothing about uppercase or underscores.

In fact, the problem in which I often find myself stuck is that I cannot separate different words in a single container name (in the fig.yml). Perhaps I'm mistaking or I didn't find the right convention to name my containers but I'm currently forced to use names like mysqldatacontainer when I would like to call them more like mysqlDataContainer or even mysql_data_container.

If I use some uppercase, I end up with this error:

Invalid repository name (appname_mysqlDataContainer), only [a-z0-9-_.] are allowed

and this one if I use a _ or a -:

Invalid service name "mysql_data_container" - only [a-zA-Z0-9] are allowed

That's why I'm proposing to allow at least one more character or to allow the uppercase in order to make long names more readable (if I didn't miss any way of doing it). We could even use it later as a coding convention.

What do you guys think about that ?

@Vrakfall Vrakfall changed the title Support for uppercase in container Support for uppercase or underscores or any separator in container names Feb 10, 2015
@dnephin
Copy link

dnephin commented Feb 10, 2015

The "Invalid repository name" error is coming from dockerd, not fig. see #655 , moby/moby@aabba98

fig/compose should be able to support other characters once docker has support for labels moby/moby#9882

@Vrakfall
Copy link
Author

Thank you for your quick answer !

Good thing if it's going to be implemented soon !

Should I leave the issue open ?

@thaJeztah
Copy link
Member

Happy to inform that support for labels (moby/moby#9882) was merged and will be included in the upcoming 1.6 release of Docker.

Also, I think there are currently a number of related issues in this area (#652, #869, #941 among others); perhaps the discussion should be focussed on the global proposal #1066 (but that's just a suggestion)

@Vrakfall
Copy link
Author

Oh, nice thing, thank you.

Waiting for the 1.6 version to test it and then I'll close this issue.

@thaJeztah
Copy link
Member

Waiting for the 1.6 version to test it and then I'll close this issue.

Well, it still depends on changes in compose itself, but the path is now clear to start working on that.

@aanand
Copy link

aanand commented Jun 5, 2015

Closing in favour of #1519

@aanand aanand closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants