Remove k8s.io/kubernetes dependency #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are only using the `IsPodReady` function that can be rewritten easily. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
|
@silvin-lubecki PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Removed the
k8s.io/kubernetesdependency, we are only using theIsPodReadyfunction that can be rewritten.This shouldn't be imported as a library anyway
- How I did it
Replaced the call to
podutils.IsPodReadywith a custom function.- How to verify it
I am not really sure, would need help if there are no tests that cover this code.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
