Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #2441

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thompson-shaun
Copy link
Collaborator

@thompson-shaun thompson-shaun commented May 2, 2024

Summary

This PR has a few changes around existing issue templates

Template updates

Bug Report Template

  • Add kind/maybe-bug label by default
  • Minor re-order of items

Feature Request Template

  • Add checklist for requirements mimicking the Bug Report template

@@ -3,6 +3,7 @@ name: Bug Report
description: Report a bug
labels:
- status/triage
- kind/bug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we originally had this, but then removed it? cc @tonistiigi

I remember a discussion (I think in the build team internal docker slack) about wanting to ensure that all issues with the label were confirmed bugs, which requires a level of triage before.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @jedevc - I had a chance to read the old thread you mentioned, and the scenario described is crucial (being able to find confirmed bugs).

The goal with this was to try and help pre-sort as the issue entered into triage and be able to identify when the issue had been responded/handled in any way. In this case, a response could include requesting more information, putting the issue into a "blocked" state but no longer requiring initial sorting. This idea stemmed from status/triage being the default state for all inbound bugs and feature requests and an assumption that the first response would get it out of that triage state to something else to avoid recycling issues. Would the addition of a verified (or using the existing accepted label) still address your use case?

I am hoping for simplicity above all else on this front - any and all ideas would be amazing 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind/maybe-bug until confirmed? 😁

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM 🎉 Essentially anything that helps filtering!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in the kind/maybe-bug

@thompson-shaun thompson-shaun marked this pull request as draft May 6, 2024 13:29
Signed-off-by: Shaun Thompson <shaun.thompson@docker.com>
Signed-off-by: Shaun Thompson <shaun.thompson@docker.com>
Signed-off-by: Shaun Thompson <shaun.thompson@docker.com>
@thompson-shaun thompson-shaun marked this pull request as ready for review May 7, 2024 00:56
Signed-off-by: Shaun Thompson <shaun.thompson@docker.com>
@thompson-shaun thompson-shaun changed the title Update bug and feature issue templates Update issue templates, add label and stale issue/pr actions May 8, 2024
@thompson-shaun thompson-shaun changed the title Update issue templates, add label and stale issue/pr actions Update issue templates May 8, 2024
@thompson-shaun thompson-shaun marked this pull request as draft May 9, 2024 03:51
Comment on lines 67 to 81
- type: textarea
attributes:
label: Docker info
label: Builders list
description: |
Output of `docker info` command.
Output of `docker buildx ls` command.
render: text
validations:
required: true

- type: textarea
attributes:
label: Builders list
label: Docker info
description: |
Output of `docker buildx ls` command.
Output of `docker info` command.
render: text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we want to change the order?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading the attributes, I was just attempting to group docker buildx commands together -- no strong preference either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants