Remove vfs as default storage driver. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
approved these changes
Oct 31, 2017
There was a problem hiding this comment.
LGTM, thanks!
The Travis failure is 17.11-rc which is due to non-static binaries for docker-containerd* (see moby/moby#35350).
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 31, 2017
- `docker`: remove `vfs` as default `--storage-driver` (docker-library/docker#89), add `zfs` utils (docker-library/docker#87) - `ghost`: 1.16.1 - `golang`: `arm64v8` for 1.8 (new in 1.8.5) - `redmine`: skip `bundle exec` for getting the database adapter (docker-library/redmine#92) - `wordpress`: 4.8.3
This was referenced Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on of #88. The vfs storage driver is no longer defaulted to, as Docker now has more sensible defaults than it did when device mapper was used. Years ago, Docker defaulted to the devicemapper storage driver, which had issues reclaiming space and filling disks (see: moby/moby/issues/3182). I believe the reason the Docker in Docker (
dind) image defaulted to the vfs storage driver was to avoid that issue.Fortunately, since I created moby/moby/issues/3182, Docker now defaults to more flexible storage drivers such as overlay2, zfs, and btrfs, and the
dindimage no longer needs to default to vfs.This PR will improve performance of Docker in Docker images running on any of the aforementioned storage drivers.