Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid warnings about illegal reflective access #1038

Merged
merged 1 commit into from May 16, 2018

Conversation

alexanderkjall
Copy link
Contributor

@alexanderkjall alexanderkjall commented May 16, 2018

Upgrades the netty dependency, all tests are green for me locally, there is still a warning about the same thing from guice and it seems like guice haven't released a fixed version yet, there is an open bug about it here: google/guice#1133

bug reference: #1037


This change is Reviewable

@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #1038 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   59.31%   59.34%   +0.03%     
==========================================
  Files         441      441              
  Lines        8686     8686              
  Branches      528      528              
==========================================
+ Hits         5152     5155       +3     
+ Misses       3244     3243       -1     
+ Partials      290      288       -2
Impacted Files Coverage Δ
...va/org/apache/http/impl/io/ChunkedInputStream.java 60.95% <0%> (+0.95%) ⬆️
...ava/netty/handler/FramedResponseStreamHandler.java 84.48% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9712ad5...3d5aa4d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants