This repository has been archived by the owner on Mar 10, 2021. It is now read-only.
Fix Firefox extra newline bug without requiring CSS changes from user #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code introduced extra empty text nodes that were not present in the original unforked mdx-prism output. This apparently makes Firefox interpret the preceding newline as one it should actually render like any other newline in the `pre` tag. The bug is only visible at the AST level, not the toString'd output, hence the new weird test. I believe MDX turns this AST into JSX, which preserves the empty text node.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See juanbzpy#4
I've tested this in my own repo that uses this plugin on Firefox, Chrome, and an iOS 14.4 simulator. Seems to work fine in all cases.
I'll also open a PR against the upstream repo, but this one seems more likely to be merged ;)