fix: strict top offset comparison fails in headed mode #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am actually surprised by this, it looks like some kind of issues in our calculations of the position? I'd like to have all the coordinates stable between different run modes. |
|
@dmtrKovalenko |
Closed
The example for `cy.realMouseMove` was using `cy,realMouseUp`
* chore(deps-dev): bump cypress from 9.1.0 to 10.2.0 Bumps [cypress](https://github.com/cypress-io/cypress) from 9.1.0 to 10.2.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js) - [Commits](cypress-io/cypress@v9.1.0...v10.2.0) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Migrate to cypress 10 * Fix glob Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dmitriy <dmtr.kovalenko@outlook.com>
…nto fix-headed-failing-top-offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests were failing in
click.spec.ts,hover.spec.ts, andmouse.spec.tswhen I ran them locally in the Cypress Test Runner using theyarn run cypress opencommand. Please see the screenshots below.All tests passed in headless mode.
The reason for the headed failures are that the top offset of the element is expected to be an integer but the actual value has a decimal of usually 0.1875.
The fix seems quite easy and works well for me locally. I just changed the Cypress comparison to allow for the small deviation. It seems like a relatively safe change.
Closes #236
Please let me know if I missed something.