Fix data file shipping confusions on pip install for #463 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| print(output) | ||
| os.system('sh ./xgboost/build-python.sh') | ||
| else: | ||
| print 'Windows users please use github installation.' |
There was a problem hiding this comment.
This should be print() for python 3.
There was a problem hiding this comment.
@sinhrks Thanks for reminding, just pushed the change.
tqchen
added a commit
that referenced
this pull request
Oct 25, 2015
Fix data file shipping confusions on pip install for #463
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix data file shipping confusions on pip install for #463 by:
xgboost/wrapper/and deleting it during pip installation, so it can force system compilingAdd error message for windows users for less confusion.
Current pip installation should give errors when there is no gcc installed on the system, which is the right thing.