New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Make code compilable with GCC 13 #7363
base: master
Are you sure you want to change the base?
Conversation
To trigger regression tests:
|
@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13? |
Old METIS code had a compile error with GCC 13. GKLib shipped inside METIS before but now it is not so we add it as a submodule. Updating the software version should improve the experience. We don't have to be compatible but GCC 13 ships with Ubuntu 24.04. |
It is better to be compatible with this little effort and support latest OS default compiler. |
@classicsong Please help review change on |
@mfbalin As there's large time gap between the current one we're using and the new one you'd apply, it's risky and requires more reviews from other team member even the author. Let's hold on for now. |
Let's aim GS 0.3 release around July 2024, before the release there will be comprehensive test. |
Description
Updating METIS to the latest master branch. GKlib was taken out of METIS so adding it manually as a submodule. Adding missing include. The code compiles with GCC 13 (shipped with Ubuntu 24.04) with this PR.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes