Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Make code compilable with GCC 13 #7363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Apr 27, 2024

Description

Updating METIS to the latest master branch. GKlib was taken out of METIS so adding it manually as a submodule. Adding missing include. The code compiles with GCC 13 (shipped with Ubuntu 24.04) with this PR.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 27, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 27, 2024

Commit ID: 04ac372

Build ID: 1

Status: ❌ CI test failed in Stage [CPU Build (Win64)].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 28, 2024

Commit ID: 04ac372

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13?

@mfbalin
Copy link
Collaborator Author

mfbalin commented Apr 28, 2024

@mfbalin why do we need to be compatible with gcc 13? and gklib is the only blocker to be compatible with gcc 13?

Old METIS code had a compile error with GCC 13. GKLib shipped inside METIS before but now it is not so we add it as a submodule. Updating the software version should improve the experience.

We don't have to be compatible but GCC 13 ships with Ubuntu 24.04.

@mfbalin
Copy link
Collaborator Author

mfbalin commented Apr 28, 2024

It is better to be compatible with this little effort and support latest OS default compiler.

@Rhett-Ying
Copy link
Collaborator

Rhett-Ying commented Apr 28, 2024

@classicsong Please help review change on GKlib as it's quite long ago(6 years gap between the one we're using and the latest on master branch) since last change, so I'm not sure if it's safe to change it to latest.

@Rhett-Ying
Copy link
Collaborator

@mfbalin As there's large time gap between the current one we're using and the new one you'd apply, it's risky and requires more reviews from other team member even the author. Let's hold on for now.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 28, 2024

Commit ID: 0c85c11

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

Let's aim GS 0.3 release around July 2024, before the release there will be comprehensive test.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 29, 2024

Commit ID: a15c452ff619393f94c8dc3cd2410e40a629fdfd

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants