Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Fix DiskBasedFeature Memory Leak Problem #7349

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

pyynb
Copy link
Collaborator

@pyynb pyynb commented Apr 23, 2024

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 23, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 23, 2024

Commit ID: 79368c3

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@pyynb pyynb changed the title Disk feature [GraphBolt] Fix DiskBasedFeature Memory Leak Problem Apr 23, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 23, 2024

Commit ID: 14092b9

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 23, 2024

Commit ID: ef30637

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@pyynb pyynb marked this pull request as ready for review April 23, 2024 09:49
@pyynb pyynb requested a review from Rhett-Ying April 23, 2024 09:49
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 23, 2024

Commit ID: a6cc2e36fc9aa043c4b8e7e5a9223c95e7bdfd1d

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Copy link
Collaborator

@Rhett-Ying Rhett-Ying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you benchmarked the new implementation? Is it the same implementation as previous one which obtained previous benchmark results?

graphbolt/src/cnumpy.cc Outdated Show resolved Hide resolved
graphbolt/src/cnumpy.cc Outdated Show resolved Hide resolved
graphbolt/src/cnumpy.cc Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 24, 2024

Commit ID: e0c7c0e9952fb069e2118ceaa700b80d94d1c267

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 24, 2024

Commit ID: 422bd60a21e050d3681aa8c4e6c04e204e149a1a

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 24, 2024

Commit ID: cffc20e846641adfa8c07720e153c9a7970344b3

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 24, 2024

Commit ID: 2d36edcbe58468e7a33ddf3f7ff5b98df3eb063b

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 24, 2024

Commit ID: 6443d998377878b8a3f0a2e982e46b79b9b95785

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 24, 2024

Commit ID: a88145a5b432692123dacf2ccf8bba2ec696d0b1

Build ID: 10

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants