[DoNotMerge][C++Seminar] define all in header file #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
frozenbugs
reviewed
Nov 28, 2023
|
|
||
| /** @brief Manually fix the seed. */ | ||
| static std::optional<uint64_t> manual_seed; | ||
| static void SetManualSeed(int64_t seed); | ||
| static inline std::optional<uint64_t> manual_seed; |
There was a problem hiding this comment.
I didn't use inline previously, does this change the scope of the variable?
There was a problem hiding this comment.
it's for allowing definition within class instead of outside. As for scope, I think every translation unit has the identical instance of ::manual_seed no matter definitions are in header file or cc file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's the problem you hit if this PR is applied? @frozenbugs
Checklist
Please feel free to remove inapplicable items for your PR.
Changes