Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanded ssh_config parameters for qemu+ssh uri option #1059

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

memetb
Copy link

@memetb memetb commented Dec 20, 2023

Hello @dmacvicar,

this PR is in relation to the issue #1058 I recently opened.

This is a preliminary PR and work in progress. I have listed the known issues with this PR at this point. I would also like to get feedback from you before putting more effort in.

This feature is a must-have for my use case since I require to access my bare metal servers through a bastion host.

Known issues:

  1. using ProxyJump with openssh implementation of ssh will ask the bastion host to resolve the HostName. This allows for local resolution (e.g. private and/or dynamic IP addresses) to be used for the hostname resolution (i.e. a machine may have a name that is only locally resolvable on the bastion). The current code will not forward the name resolution from the bastion host.
  2. there is a hardcoded maximum depth of 10 jump hosts
    3. little to no effort on code style and documentation: this was a quick and dirty feature feasibility test to see if the desired workflow worked correctly
  3. no unit tests have been added

Memet Bilgin added 22 commits December 20, 2023 19:00
this allows different hosts (jump hosts) to have different identity files
specified
the hostKeyCallback makes use of the SSH port and fails if a custom ssh port is
being used by the host
this value was chosen as the lowest RSA available by default on a debian build
running OpenSSH_9.2 and works out of the box for most hosts tested by authority.
Any older systems can specifically set their key algorithms in .ssh/config
@memetb memetb marked this pull request as ready for review February 22, 2024 16:13
@memetb memetb changed the title WIP: expanded ssh_config parameters for qemu+ssh uri option expanded ssh_config parameters for qemu+ssh uri option Feb 22, 2024
@memetb memetb mentioned this pull request Feb 22, 2024
@tuxillo
Copy link

tuxillo commented Mar 5, 2024

will this ever be merged?

@memetb
Copy link
Author

memetb commented Mar 5, 2024

@tuxillo fyi, I'm using my forked project in production. I haven't published that project on terraform specifically because I want to keep the noise ratio down, but if you so wish, you can use the forked project's production branch which has this merged as well as a couple of other small features merged in.

@gthieleb
Copy link

@tuxillo fyi, I'm using my forked project in production. I haven't published that project on terraform specifically because I want to keep the noise ratio down, but if you so wish, you can use the forked project's production branch which has this merged as well as a couple of other small features merged in.

@dmacvicar This looks like good improvement regarding the ssh connection. May you have a look regarding compatibility, etc. if this can be merged into upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants