utils_xslt: display xsltproc stderr when it fails #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easy to have xsltproc failing to process the XML from a libvirt
terraform configuration. Indeed, syntax error will trigger such failure,
and a bad terraform configuration where xslt= property is confused as
file path instead of content would likely generate syntax errors:
resource "libvirt_domain" "example" {
# ...
xml {
xslt = "${path.module}/transform.xslt"
}
}
Currently, when xsltproc fails, with TF_LOG=1, the following is
displayed:
2023-02-21T14:00:35.620+0100 [INFO] provider.terraform-provider-libvirt: 2023/02/21 14:00:35 [ERROR] Failed to run xsltproc (is it installed?): timestamp=2023-02-21T14:00:35.620+0100
Which is confusing when xsltproc is available. With this patch and
TF_LOG=1, the following would be displayed:
2023-02-21T14:00:35.620+0100 [INFO] provider.terraform-provider-libvirt: 2023/02/21 14:00:35 [ERROR] Failed to run xsltproc (is it installed?): timestamp=2023-02-21T14:00:35.620+0100
2023-02-21T14:00:35.620+0100 [INFO] provider.terraform-provider-libvirt: 2023/02/21 14:00:35 [ERROR] Error: {/tmp/terraform-provider-libvirt-xslt1179436507:1: parser error : Start tag expected, '<' not found
transform.xslt
^
Refs dmacvicar#999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easy to have xsltproc failing to process the XML from a libvirt terraform configuration. Indeed, syntax error will trigger such failure, and a bad terraform configuration where xslt= property is confused as file path instead of content would likely generate syntax errors:
Currently, when xsltproc fails, with TF_LOG=1, the following is displayed:
Which is confusing when xsltproc is available. With this patch and TF_LOG=1, the following would be displayed:
Refs #999
Please make sure you read the contributor documentation before opening a Pull Request.