fix(percent formatStyle): parsing causes accuracy issues with higher …

…precisions
dm4t2 · Nov 3, 2021 · 2b2f8c3 · 2b2f8c3
1 parent 695e9ca
commit 2b2f8c3
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 3 deletions.
diff --git a/src/numberFormat.ts b/src/numberFormat.ts
@@ -69,11 +69,12 @@ export class NumberFormat {
       const fraction = this.decimalSymbol ? `(?:${escapeRegExp(this.decimalSymbol)}(\\d*))?` : ''
       const match = this.stripGroupingSeparator(str).match(new RegExp(`^${INTEGER_PATTERN}${fraction}$`))
       if (match && this.isValidIntegerFormat(this.decimalSymbol ? str.split(this.decimalSymbol)[0] : str, Number(match[1]))) {
-        let number = Number(`${negative ? '-' : ''}${this.onlyDigits(match[1])}.${this.onlyDigits(match[2] || '')}`)
+        const number = Number(`${negative ? '-' : ''}${this.onlyDigits(match[1])}.${this.onlyDigits(match[2] || '')}`)
         if (this.style === NumberFormatStyle.Percent) {
-          number /= 100
+          return Number((number / 100).toFixed(this.maximumFractionDigits + 2))
+        } else {
+          return number
         }
-        return number
       }
     }
     return null

diff --git a/tests/unit/__snapshots__/numberFormat.spec.ts.snap b/tests/unit/__snapshots__/numberFormat.spec.ts.snap
@@ -465,6 +465,37 @@ NumberFormat {
 }
 `;
 
+exports[`NumberFormat constructing number formats percent de-DE 1`] = `
+NumberFormat {
+  "currency": undefined,
+  "currencyDisplay": undefined,
+  "decimalSymbol": ",",
+  "digits": Array [
+    "0",
+    "1",
+    "2",
+    "3",
+    "4",
+    "5",
+    "6",
+    "7",
+    "8",
+    "9",
+  ],
+  "groupingSymbol": ".",
+  "locale": "de-DE",
+  "maximumFractionDigits": 0,
+  "minimumFractionDigits": 0,
+  "minusSymbol": "-",
+  "negativePrefix": "-",
+  "prefix": "",
+  "style": "percent",
+  "suffix": " %",
+  "unit": undefined,
+  "unitDisplay": undefined,
+}
+`;
+
 exports[`NumberFormat constructing number formats unit de-DE 1`] = `
 NumberFormat {
   "currency": undefined,

diff --git a/tests/unit/numberFormat.spec.ts b/tests/unit/numberFormat.spec.ts
@@ -552,6 +552,15 @@ describe('NumberFormat', () => {
     })
 
     describe('percent', () => {
+      it('de-DE', () => {
+        expect(
+          new NumberFormat({
+            formatStyle: NumberFormatStyle.Percent,
+            locale: 'de-DE'
+          })
+        ).toMatchSnapshot()
+      })
+
       describe('parse', () => {
         it('should parse a formatted number', () => {
           expect(
@@ -568,6 +577,16 @@ describe('NumberFormat', () => {
             }).parse('123,400%')
           ).toBe(1234)
         })
+
+        it('should return the parsed value with a fixed precision', () => {
+          expect(
+            new NumberFormat({
+              formatStyle: NumberFormatStyle.Percent,
+              locale: 'en',
+              precision: 5
+            }).parse('0.9%')
+          ).toBe(0.009)
+        })
       })
     })
   })