Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premature error fix for issue #353 #357

Closed
wants to merge 4 commits into from

Commits on Apr 17, 2024

  1. fix(keybinds): Address premature error re; dlvhdr#353

    Removes an assumption that specific data/keys are required by the bound
    command.
    
    Instead `Template.Option()` is used to tell the Template to error out if
    and when it actually encounters a key it needs.
    Omnikron13 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9c02ccc View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    e189492 View commit details
    Browse the repository at this point in the history
  2. fix(keybinds): replace struct with map for template inputs (dlvhdr#353)

    Unfortuneatly it seems the Template options are a little lacking, and
    I don't believe can be persuaded to accept zero values or even nil
    pointers as 'missing' values.
    
    The struct in question, `PRCommandTemplateInput`, appears to have no use
    elsewhere however, so was easily replaced with a map, which I hope
    serves your needs for the near future at least.
    Omnikron13 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bf2338e View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Configuration menu
    Copy the full SHA
    cce3e09 View commit details
    Browse the repository at this point in the history