Deprecate default_path support in repoPaths configuration
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we support the more general `:owner/:repo` template configuration (85a75fe), the prior `default_path` functionality (d9ef14a) is redundant - e.g. this configuration: ``` default_path: ~/code/repos ``` can be achieved with: ``` :owner/:repo: ~/code/repos/:repo ``` Thus, we are deprecating the `default_path` syntax. It's still supported but will be removed in the next major version.
|
Might be worth running a quick code search to see how many use this. Something like: |
|
There are 2 results (and one commented-out value) for that query: That said, I'm not sure how representative this is, given that many folks might not push their dash config to a public GItHub repo. |
|
Ok cool, then given this not very scientific way, lets remove the default path entirely 😀 |
|
Ok sounds good! I've opened a new PR to remove |
rmacklin
deleted the
deprecate-default_path-support-in-repoPaths-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we support the more general
:owner/:repotemplate configuration (#343), the priordefault_pathfunctionality (#327) is redundant - e.g. this configuration:can be achieved equivalently with:
Thus, we are deprecating the
default_pathsyntax. It's still supported but will be removed in the next major version.How did you test this change?
This is just a documentation change.