Fix CPUX pushm/popm for address words #122
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the "step_pushm_popm" function for the CPUX simulator, which originally 1) decoded PUSHM.A and POPM.A instructions incorrectly and 2) treated all PUSHM/POPM instructions as 16-bit word accesses, which caused programs using 20-bit address words to crash. After patch, simulation of my test binary matched operation on a physical MSP430FR5994.