Add :xml subPackage for dlangui to use #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mention that I didn't test this... but ugh it should be ok |
|
AIU undead.xml compiles with gdc just fine (it depends only on phobos), it's undead.stream that doesn't compile, and dub compiles all files in a package. The package won't compile until all files in the package compile. |
Correct, as that old module relies on the discouraged use of RTTI based varargs. |
|
Once my PR is merged, this should be closed. We could probably close it now. |
|
I think this can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grim isn't too happy that undead isn't building with GDC, this extracts it so it can be used by dlangui until a better solution is found.