co-locate overloads of std.algorithm.mutation.swap() #8951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
requested review from
andralex,
JackStouffer,
wilzbach and
PetarKirov
as code owners
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8951" |
WalterBright
force-pushed
the
swapOverload
branch
2 times, most recently
from
67246e1
to
41a1d0f
Compare
|
Gave up on the own message and the merge. Just co-located them. |
WalterBright
force-pushed
the
swapOverload
branch
from
41a1d0f
to
d3924f2
Compare
WalterBright
changed the title
|
dstyle fails with no message. |
dkorpel
reviewed
Mar 19, 2024
It looks like DScanner was stuck in a loop for an hour and got terminated |
Co-authored-by: Dennis <dkorpel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two overloads are widely separated. This puts them together for easier study. The changes are mostly indenting.
Also has its own error message rather than the compiler generated one.