Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.mak: Change the meaning of DMD_DIR to the path of the compiler source #8820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

the-horo
Copy link
Contributor

Change the meaning of DMD_DIR from the path of the dmd repository, including the compiler and druntime, to the path of the compiler source. This becomes consistent with its usage in druntime's makefiles.

Change the meaning of DMD_DIR from the path of the dmd repository,
including the compiler and druntime, to the path of the compiler
source. This becomes consistent with its usage in druntime's
makefiles.

Signed-off-by: Horodniceanu Andrei <a.horodniceanu@proton.me>
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @the-horo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8820"

@RazvanN7
Copy link
Collaborator

This PR seems to add complexity to the paths in the makefile (by adding an extra ..) rather than simplify anything.

@the-horo
Copy link
Contributor Author

I ask for this change because of the layout of the linux source archives at https://downloads.dlang.org where the 3 main components of dmd (the compiler, druntime and phobos) are found under src/{dmd,druntime,phobos}. Being able to specify the directory of the compiler sources will help avoid having to mv directories in a way that include $(DMD_DIR)/compiler/src/osmodel.mak is satisfied.

Technically, this is not an issue because I already have to move the directories to satisfy include $(DMD_DIR)/src/osmodel.mak, the line prior to the druntime and dmd merge, (src/dmd would have to become dmd/src).

Merging this PR would simplify my workflow a little bit but, given that this has been an issue since the dmd and druntime merge, and I didn't find anyone else requesting such a change perhaps not that many people are affected, in which case I understand the complexity I add is not worth it. In this case I would still like to add a comment explaining how the DMD_DIR variable has a different meaning in phobos/posix.mak compared to druntime/posix.mak though it has the same name. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants