Placate a bunch of Allman style violation for #8805 #8817
Conversation
I don't necessarily agree with all of these but they show up as conflict for the other PR. This is a subset, I'll do the other ones later.
thewilsonator
requested review from
CyberShadow,
jmdavis,
MetaLang,
PetarKirov,
dnadlinger,
ibuclaw,
andralex,
wilzbach and
JackStouffer
as code owners
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8817" |
| () @trusted | ||
| { |
There was a problem hiding this comment.
specifically I don't like this type of change
There was a problem hiding this comment.
this definitely looks more correct for allman style, would not remove this from D-Scanner but possibly add some kind of config for this
There was a problem hiding this comment.
That would be great, thanks!
| @@ -1208,7 +1209,8 @@ if (!(is(S : T) && | |||
| */ | |||
| private template isSwitchable(E) | |||
| { | |||
| enum bool isSwitchable = is(typeof({ | |||
There was a problem hiding this comment.
and I really don't like this type of change
There was a problem hiding this comment.
yeah this looks like a bug in D-Scanner
|
Can we fix Dscanner instead? |
|
any update on this? |
|
ah none yet, I forgot about this PR |
|
ping |
how about stop using it, even. Enforce trivial matters of style with a formatter, not a linter. |
I don't necessarily agree with all of these but they show up as conflict for the other PR.
This is a subset, I'll do the other ones later.