Allow new shared FileLogger()
#8783
Conversation
|
Thanks for your pull request and interest in making D better, @atilaneves! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8783" |
atilaneves
force-pushed
the
new-shared-filelogger
branch
from
4f883a2
to
6ba05fa
Compare
atilaneves
force-pushed
the
new-shared-filelogger
branch
from
6ba05fa
to
e9ec8df
Compare
std/logger/filelogger.d
Outdated
| @@ -80,7 +80,10 @@ class FileLogger : Logger | |||
| " created in '", d,"' could not be created.")); | |||
| } | |||
|
|
|||
| this.file_.open(this.filename, "a"); | |||
| static if (is(This == shared)) | |||
| () @trusted { (cast() this.file_).open(this.filename, "a"); }(); | |||
There was a problem hiding this comment.
Just do this all the time? Then no need to template the constructor, add a comment about why.
There was a problem hiding this comment.
The constructor still needs to be templated, though.
No description provided.