LDC: Don't keep around temporary object files for static libs #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 14 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5280256 bin/dub
-rough build time=76s
+rough build time=77sFull build output |
This was a workaround for older LDC versions. Since LDC v1.25, `-cleanup-obj` implies that the temporary object files are placed into a unique temp directory (per compiler invocation), so that object file collisions across parallel dub invocations cannot happen anymore.
kinke
force-pushed
the
ldc_temp_objects
branch
from
7eae6f1
to
050ca7f
Compare
WebFreak001
reviewed
Aug 24, 2023
| settings.addDFlags("-lib"); | ||
| // -oq: name object files uniquely (so the files don't collide) | ||
| // -cleanup-obj: remove object files after archiving to static lib, and put them in a unique temp directory | ||
| settings.addDFlags("-lib", "-oq", "-cleanup-obj"); |
There was a problem hiding this comment.
are the new flags not required for the dynamicLibrary case below?
There was a problem hiding this comment.
Nope; the object files for executables and shared libs are persisted/kept around, by dub and the compilers alike. Static libs with DMD are a special case, as it writes the static lib directly itself, without creating separate object files and then archiving them, like LDC and GDC. ldmd2 -lib also injects these 2 extra flags for the ldc2 cmdline to mimic the DMD behavior.
WebFreak001
reviewed
Aug 24, 2023
|
|
||
| exit 0 | ||
| numObjectFiles=$(find "$DUB_CACHE_PATH" -type f -iname '*.o*' | wc -l) | ||
| [ "$numObjectFiles" -eq 0 ] || die $LINENO "Found left-over object files in $DUB_CACHE_PATH" |
There was a problem hiding this comment.
this change seems to revert what has previously been published in the changelogs: kinke@176ea9c
Enables co-existence and parallel compilation of the same project with different settings (e.g. cross compilation) by moving
.dub/objto$DUB_TARGET_PATH/obj.
Although that changelog entry seems faulty right now, since it didn't actually write to the target path (e.g. "targetPath": "bin") but to the build cache path.
So I think this change is fine.
There was a problem hiding this comment.
With LDC v1.25+, this PR solves the concurrency problem more robustly - each compiler invocation uses a unique temp dir for its object files, no need to specify unique-ish paths explicitly.
WebFreak001
reviewed
Aug 24, 2023
|
The flag was introduced in LDC v1.1 in 2016: ldc-developers/ldc@141310c It's just that since v1.25 it additionally implies a concurrent-safe unique temp dir instead of the cwd (if you don't specify a |
…ocesses somehow] On macOS at least, according to CI - LDC newly creates the object files in a unique temp dir, and TMPDIR is used as parent dir. The directory doesn't exist yet for the initial build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a workaround for older LDC versions. Since LDC v1.25,
-cleanup-objimplies that the temporary object files are placed into a unique temp directory (per compiler invocation), so that object file collisions across parallel dub invocations cannot happen anymore.