This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Modify GC.stats to allow requesting specific stats
#2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihails-strasuns-sociomantic
requested review from
andralex and
DmitryOlshansky
as code owners
|
Thanks for your pull request, @mihails-strasuns-sociomantic! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2193" |
mihails-strasuns-sociomantic
requested review from
MartinNowak,
rainers and
wilzbach
as code owners
|
(in the meanwhile I am trying to implement alternative to resurrect #2164) |
|
As I said in #1846 (comment), I think the right approach is to enable/disable stats calculation globally instead of doing it at query-time, as we should aim to completely remove the heavy calculations when using Unfortunately I didn't have the time yet to try to move forward with this... |
n8sh
reviewed
Jun 12, 2018
thewilsonator
force-pushed
the
query-stats
branch
from
ddb496d
to
13420ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to #2155 and #1846 and potentially more future PRs. This should be a mostly backwards-compatible change
that enables adding more stats with less performance concerns.
Natural drawback is of course that it will only work until
Statshas 64+ fields :) Alternative I have in mind is to defineOptionaltype in druntime and use that forStatsfields - but that is quite more intrusive change.