New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a note #16472
base: master
Are you sure you want to change the base?
Adding a note #16472
Conversation
Thanks for your pull request and interest in making D better, @trikko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16472" |
Don't merge this yet, I want to improve the wording |
Improve message about VS envvars.
@trikko could you fill in the TODO with whatever it was that you did with Github action to make it work? (and remove the trailing space from the line that causes the |
I use this https://github.com/trikko/etichetta/blob/e39fd74f352aeacd6529701c2e878dd81e7ae34b/.github/workflows/windows.yml#L35 but I think it would be nice to have it integrated with dlang action. |
@@ -138,6 +138,9 @@ typedef unsigned long long __uint64_t; | |||
|
|||
// This header disables the Windows API Annotations macros | |||
// Need to include sal.h to get the pragma once to prevent macro redefinition. | |||
// Note: these includes require include paths to `cl.exe` as envoronment variables that are set by | |||
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions | |
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Github actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, but this should get overwritten at some point anyway.
I’m adding this note because it took me a while to understand why the compilation with importc wasn’t working when using GitHub Actions: it was necessary to set up the environment with vcvars.