Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note #16472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding a note #16472

wants to merge 2 commits into from

Conversation

trikko
Copy link
Contributor

@trikko trikko commented May 11, 2024

I’m adding this note because it took me a while to understand why the compilation with importc wasn’t working when using GitHub Actions: it was necessary to set up the environment with vcvars.

@trikko trikko requested a review from ibuclaw as a code owner May 11, 2024 13:16
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @trikko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16472"

@thewilsonator
Copy link
Contributor

Don't merge this yet, I want to improve the wording

Improve message about VS envvars.
@thewilsonator
Copy link
Contributor

thewilsonator commented May 12, 2024

@trikko could you fill in the TODO with whatever it was that you did with Github action to make it work? (and remove the trailing space from the line that causes the pre-commit to fail)

@trikko
Copy link
Contributor Author

trikko commented May 12, 2024

I use this https://github.com/trikko/etichetta/blob/e39fd74f352aeacd6529701c2e878dd81e7ae34b/.github/workflows/windows.yml#L35 but I think it would be nice to have it integrated with dlang action.

@@ -138,6 +138,9 @@ typedef unsigned long long __uint64_t;

// This header disables the Windows API Annotations macros
// Need to include sal.h to get the pragma once to prevent macro redefinition.
// Note: these includes require include paths to `cl.exe` as envoronment variables that are set by
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions
Copy link
Member

@maxhaton maxhaton May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Gitbub actions
// executing `vcvarsall.bat` (this is automatically done when using a VS command propmt). -- TODO Github actions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, but this should get overwritten at some point anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants