Fix Bugzilla 21564 - assignment syntax for instantiating mixin templates #16387
Conversation
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16387" |
compiler/src/dmd/parse.d
Outdated
| AST.Objects* tiargs; | ||
|
|
||
| //printf("parseMixin()\n"); | ||
| const locMixin = token.loc; | ||
| nextToken(); // skip 'mixin' | ||
|
|
||
| // mixin identifier = MixinTemplateName TemplateArguments; |
There was a problem hiding this comment.
Identifier
Grammar terms should be capitalized
compiler/src/dmd/parse.d
Outdated
| @@ -1780,14 +1787,14 @@ class Parser(AST, Lexer = dmd.lexer.Lexer) : Lexer | |||
| nextToken(); | |||
| } | |||
|
|
|||
| id = null; | |||
| if (token.value == TOK.identifier) | |||
| // mixin MixinTemplateName TemplateArguments identifier; | |||
| * mixin a.b.c!(args).Foo!(args); | ||
| * mixin Foo!(args) identifier; | ||
| * mixin typeof(expr).identifier!(args); |
There was a problem hiding this comment.
Only a small nit, I don't see a need to remove this comment at the top of the function.
Adding in the new syntax style would make it clear that this is also handled by parseMixin.
…templates Following the [alias this change](https://dlang.org/changelog/2.105.0.html#dmd.alias-this-syntax), I think mixin instantiation was the last place not using assignment syntax.
Following the alias this change, I think mixin instantiation was the last place not using assignment syntax.